Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update admin rereplicate command to support SQL databases #4227

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

Shaddoll
Copy link
Member

What changed?
Update admin rereplicate command to support SQL databases

Why?
To address #2777.

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented May 29, 2021

Pull Request Test Coverage Report for Build 1b1a0a40-8ae6-433a-94e8-8eebde7149f2

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 19 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.02%) to 60.273%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cli/adminKafkaCommands.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
tools/cli/adminKafkaCommands.go 1 0%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/queue/timer_queue_processor.go 2 58.77%
service/history/queue/timer_gate.go 3 95.83%
service/history/queue/timer_queue_processor_base.go 4 78.83%
service/history/execution/mutable_state_task_refresher.go 7 72.32%
Totals Coverage Status
Change from base Build a454c440-4d47-41ca-ad49-d2178b139c3d: 0.02%
Covered Lines: 89081
Relevant Lines: 147797

💛 - Coveralls

@yycptt yycptt requested a review from yux0 June 3, 2021 18:35
Copy link
Contributor

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yux0 Do we still need this command? I think it's only for kafka based replication?

Nvm. Looks like the comment is outdated.

Copy link
Contributor

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the comment for this command? I think it's not publishing tasks to kafka anymore.

@Shaddoll Shaddoll merged commit 263227f into cadence-workflow:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants