Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra implementation for cross cluster queue #4237

Merged
merged 9 commits into from
Jun 1, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented May 28, 2021

What changed?

  • Cassandra implementation for cross cluster queue
  • Some refactor for persistence tests

Why?
For supporting cross domain operations

How did you test it?
Added new persistence tests for cross cluster queue

Potential risks
In the worst case, create/updateWorkflowExecution operation may fail for cassandra

Release notes
Cassandra schema version updated to v0.31

Documentation Changes

@yycptt yycptt requested review from yux0 and a team May 28, 2021 22:57
@coveralls
Copy link

coveralls commented May 28, 2021

Pull Request Test Coverage Report for Build 7f484412-7964-4a3d-9b72-f3f9a35e737e

  • 69 of 872 (7.91%) changed or added relevant lines in 8 files are covered.
  • 17 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.1%) to 60.142%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/dataInterfaces.go 38 46 82.61%
common/persistence/persistence-tests/persistenceTestBase.go 0 49 0.0%
common/persistence/cassandra/cassandraPersistence.go 0 67 0.0%
common/persistence/cassandra/cassandraPersistenceUtil.go 12 82 14.63%
common/persistence/persistence-tests/shardPersistenceTest.go 0 268 0.0%
common/persistence/persistence-tests/executionManagerTest.go 0 341 0.0%
Files with Coverage Reduction New Missed Lines %
common/task/fifoTaskScheduler.go 2 87.63%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/queue/timer_queue_processor.go 2 58.77%
common/cache/lru.go 3 90.73%
common/persistence/cassandra/cassandraPersistenceUtil.go 8 88.43%
Totals Coverage Status
Change from base Build 6c9def8d-f9ad-48d3-b038-2ff0e968f28d: -0.1%
Covered Lines: 88605
Relevant Lines: 147326

💛 - Coveralls

@yycptt yycptt merged commit 6f77ae2 into cadence-workflow:master Jun 1, 2021
@yycptt yycptt deleted the cass-cross-cluster-queue branch June 1, 2021 20:18
@demirkayaender
Copy link
Member

This change seems to be breaking server.

{"level":"error","ts":"2021-06-07T22:31:33.266-0700","msg":"Internal service error","service":"cadence-history","error":"InternalServiceError{Message: UpdateShard operation failed. Error: Unknown field 'cross_cluster_processing_queue_states' in value of user defined type shard}","wf-id":"helloworld_09115e1c-329f-432d-b1ba-927ac4b513a7","wf-domain-id":"a29d9450-280c-4f6d-8c9e-ac896cbc02a9","logging-call-at":"handler.go:1907","stacktrace":"github.com/uber/cadence/common/log/loggerimpl.(*loggerImpl).Error ...}

To repro, you can run helloworkflow and trigger it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants