Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change domain data CLI parameter for consistency #4240

Merged
merged 2 commits into from
May 29, 2021

Conversation

longquanzheng
Copy link
Contributor

@longquanzheng longquanzheng commented May 29, 2021

What changed?
Change domain data CLI parameter for consistency

Why?
A followup to #4226
This is to unify all map paramter in CLI for consistency. This will be much easier for users using CLI.

How did you test it?
local tested

qlong@~/cadence:
(qlong-cli-map-consistence)$./cadence --do test-do-data d re --domain_data k1=v1,k2=v2
Domain test-do-data successfully registered.
qlong@~/cadence:
(qlong-cli-map-consistence)$./cadence --do test-do-data d desc
Name: test-do-data
UUID: 8ec4f4e8-cd7b-4aa0-8064-9575f06f64d0
Description:
OwnerEmail:
DomainData: map[k1:v1 k2:v2]
...

(qlong-cli-map-consistence)$./cadence --do test-do-data d up --domain_data k1=v11,k2=v22
Domain test-do-data successfully updated.
qlong@~/cadence:
(qlong-cli-map-consistence)$./cadence --do test-do-data d desc
Name: test-do-data
UUID: 8ec4f4e8-cd7b-4aa0-8064-9575f06f64d0
Description:
OwnerEmail:
DomainData: map[k1:v11 k2:v22]
...

Potential risks
N/A

Release notes
Updated

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 08b64f95-1d65-4a2e-9ddb-715f33c28296

  • 4 of 7 (57.14%) changed or added relevant lines in 1 file are covered.
  • 112 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.05%) to 60.228%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cli/domainCommands.go 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
host/signalworkflowTest.go 1 95.53%
service/history/execution/mutable_state_task_refresher.go 1 75.23%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/queue/timer_queue_processor.go 2 58.77%
service/matching/matcher.go 2 91.46%
service/history/queue/timer_queue_processor_base.go 4 78.83%
common/task/fifoTaskScheduler.go 5 84.54%
common/persistence/cassandra/cassandraPersistence.go 6 56.68%
common/persistence/cassandra/cassandraPersistenceUtil.go 89 87.05%
Totals Coverage Status
Change from base Build 34dc7e72-9834-4b69-aed0-f746ca970709: -0.05%
Covered Lines: 88501
Relevant Lines: 146944

💛 - Coveralls

@longquanzheng longquanzheng merged commit 84059fb into master May 29, 2021
@longquanzheng longquanzheng deleted the qlong-cli-map-consistence branch May 29, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants