Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shardContext for getting and updating cross-cluster queue states #4246

Merged

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Jun 2, 2021

What changed?

  • Add methods to shardContext for getting and updating cross-cluster processing queue states
  • Use processing queue states and failover markers fields in shardInfo directly
  • Remove unused Replicator related methods from shardContext.

Why?
For supporting cross-domain operations.

How did you test it?
Unit tests.

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested review from yux0, demirkayaender and a team June 2, 2021 17:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018ab638-5cdd-4faf-aa8f-5426254c195a

  • 71 of 101 (70.3%) changed or added relevant lines in 4 files are covered.
  • 51 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.03%) to 60.192%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/shard/context.go 35 48 72.92%
common/persistence/persistence-tests/shardPersistenceTest.go 0 17 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 78.6%
common/membership/rpServiceResolver.go 2 73.58%
common/task/fifoTaskScheduler.go 2 85.57%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/task/transfer_active_task_executor.go 2 69.31%
service/matching/taskListManager.go 2 74.72%
common/persistence/cassandra/cassandraPersistence.go 3 52.45%
service/history/shard/context.go 4 65.83%
common/persistence/cassandra/cassandraPersistenceUtil.go 33 87.02%
Totals Coverage Status
Change from base Build 0070ea5b-16ac-4631-a33f-b54e7d3684b0: 0.03%
Covered Lines: 88688
Relevant Lines: 147342

💛 - Coveralls

@yycptt yycptt merged commit 3eda53b into cadence-workflow:master Jun 3, 2021
@yycptt yycptt deleted the shard-context-cross-cluster-queue branch June 3, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants