Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cassandra schema version check #4247

Merged

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Jun 2, 2021

What changed?

  • Fix Cassandra schema version check

Why?
Cassandra field in Datastore config is deprecated as part of the nosql plugin refactoring. As a result, the schema version check for cassandra is skipped on service start up.

How did you test it?
Tested locally.

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested review from longquanzheng and a team June 2, 2021 23:55
@coveralls
Copy link

coveralls commented Jun 3, 2021

Pull Request Test Coverage Report for Build ceff7365-c807-42d7-a66a-ac213962655b

  • 0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
  • 67 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.04%) to 60.231%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cassandra/handler.go 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
tools/cassandra/handler.go 1 12.78%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
common/cache/lru.go 3 90.73%
common/persistence/cassandra/cassandraPersistence.go 3 54.42%
common/persistence/cassandra/cassandraPersistenceUtil.go 58 85.37%
Totals Coverage Status
Change from base Build 28a8ed6c-64ac-46ea-b6a2-963b3fc1a106: 0.04%
Covered Lines: 88879
Relevant Lines: 147563

💛 - Coveralls

@yycptt yycptt merged commit 7af95b7 into cadence-workflow:master Jun 3, 2021
@yycptt yycptt deleted the fix-cass-schema-version-check branch June 3, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants