Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate cross cluster tasks in mutable state task generator #4250

Merged
merged 3 commits into from
Jun 10, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Jun 4, 2021

What changed?

  • Generate cross cluster tasks in mutable state task generator
  • Allocate cross cluster taskID and timestamp in shardContext

Why?

  • For supporting cross-domain operations

How did you test it?

  • Unit test

Potential risks
N/A, currently cross-domain/cluster operation is not allowed in decision checker.

Release notes

Documentation Changes

@yycptt yycptt requested review from yux0, demirkayaender and a team June 4, 2021 17:12
@coveralls
Copy link

coveralls commented Jun 4, 2021

Pull Request Test Coverage Report for Build a25c3f80-2472-4755-8bad-a4990f87a5d3

  • 29 of 43 (67.44%) changed or added relevant lines in 6 files are covered.
  • 98 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.04%) to 60.206%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/historyEngine.go 0 1 0.0%
service/history/shard/context.go 8 12 66.67%
service/history/execution/mutable_state_builder.go 11 20 55.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/cassandra/cassandraPersistenceUtil.go 2 86.9%
common/task/fifoTaskScheduler.go 2 87.63%
service/matching/matcher.go 2 91.46%
common/persistence/executionStore.go 4 75.5%
common/persistence/statsComputer.go 4 95.71%
service/history/shard/context.go 16 65.13%
common/persistence/sql/sqlExecutionManager.go 17 62.04%
common/persistence/cassandra/cassandraPersistence.go 20 52.45%
service/history/execution/context.go 31 66.78%
Totals Coverage Status
Change from base Build d1612efc-d52b-4488-a809-6b2617c7dbeb: -0.04%
Covered Lines: 88931
Relevant Lines: 147712

💛 - Coveralls

@yycptt yycptt force-pushed the cross-cluster-task-generation branch from 357c5c4 to 3e216fd Compare June 10, 2021 19:07
@yycptt yycptt merged commit 42caee5 into cadence-workflow:master Jun 10, 2021
@yycptt yycptt deleted the cross-cluster-task-generation branch June 10, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants