-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix styles and instructions in docs #4260
Conversation
Make it consistent with /docs/setup/MYSQL_SETUP.md
> GRANT All Privileges to 'uber'; | ||
|
||
> CREATE USER 'uber'@'%' IDENTIFIED BY 'uber'; | ||
> GRANT ALL PRIVILEGES ON *.* TO 'uber'@'%'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be fine but just want to check, do you know what's the differences? It seems like All is more than .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also what difference it makes for 'uber'@'%'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GRANT ALL PRIVILEGES TO 'uber'@'%';
withoutON *.*
doesn't work on MySQL8.0 via docker, I know I should've used 5.7. For people didn't read all the full documentation,docker pull mysql
will pull8.*
version.The host name part of the account name, if omitted, defaults to '%'.
, I just copied them from /docs/setup/MYSQL_SETUP.md and /docker/buildkite/mysql-init/init.sql, so they look the same.
Just two comments about information. The PR LGTM. Thanks for fixing them! |
Pull Request Test Coverage Report for Build 9f53da8d-0b95-4b11-be23-3ac08cc589bd
💛 - Coveralls |
Why?
Improve docs quality
How did you test it?
No tests required
Potential risks
No
Release notes
Documentation Changes