Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styles and instructions in docs #4260

Merged
merged 5 commits into from
Jun 9, 2021

Conversation

calvinxiao
Copy link
Contributor

  1. Make command to create MySQL user consistent across docs and init.sql
  2. Remove markdown syntax in code blocks
  3. Fix some markdown style problems

Why?
Improve docs quality

How did you test it?
No tests required

Potential risks
No

Release notes

Documentation Changes

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2021

CLA assistant check
All committers have signed the CLA.

@yycptt yycptt requested a review from longquanzheng June 8, 2021 22:22
> GRANT All Privileges to 'uber';

> CREATE USER 'uber'@'%' IDENTIFIED BY 'uber';
> GRANT ALL PRIVILEGES ON *.* TO 'uber'@'%';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be fine but just want to check, do you know what's the differences? It seems like All is more than .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also what difference it makes for 'uber'@'%'?

Copy link
Contributor Author

@calvinxiao calvinxiao Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. GRANT ALL PRIVILEGES TO 'uber'@'%'; without ON *.* doesn't work on MySQL8.0 via docker, I know I should've used 5.7. For people didn't read all the full documentation, docker pull mysql will pull 8.* version.
  2. The host name part of the account name, if omitted, defaults to '%'., I just copied them from /docs/setup/MYSQL_SETUP.md and /docker/buildkite/mysql-init/init.sql, so they look the same.

@longquanzheng
Copy link
Contributor

Just two comments about information. The PR LGTM. Thanks for fixing them!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9f53da8d-0b95-4b11-be23-3ac08cc589bd

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 126 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.05%) to 60.22%

Files with Coverage Reduction New Missed Lines %
common/persistence/executionStore.go 2 75.75%
common/persistence/statsComputer.go 2 96.43%
common/persistence/serialization/parser.go 4 69.32%
common/persistence/serialization/thrift_decoder.go 4 63.44%
common/task/fifoTaskScheduler.go 5 82.47%
service/history/queue/processor_base.go 7 61.82%
service/history/shard/context.go 8 65.83%
common/persistence/sql/workflowStateMaps.go 12 83.12%
common/persistence/serialization/getters.go 16 60.69%
service/history/execution/context.go 17 68.39%
Totals Coverage Status
Change from base Build bcd1b045-6c8d-4f71-a965-6277827d7a0f: -0.05%
Covered Lines: 88869
Relevant Lines: 147574

💛 - Coveralls

@longquanzheng longquanzheng merged commit 23fbb4f into cadence-workflow:master Jun 9, 2021
@calvinxiao calvinxiao deleted the docs-fix branch June 9, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants