Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add domain tag for skip task metrics and logs #4293

Merged
merged 3 commits into from
Jul 2, 2021
Merged

Add domain tag for skip task metrics and logs #4293

merged 3 commits into from
Jul 2, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Jul 2, 2021

What changed?

  • Add domain tag for skip task metrics and logs

Why?

  • Add domain tag for skip task metrics and logs

How did you test it?

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested a review from a team July 2, 2021 17:07
@coveralls
Copy link

coveralls commented Jul 2, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build fe25ace9-4706-4a96-a445-08cd2c97e0ad

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.07%) to 59.766%
Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 74.4%
common/membership/rpServiceResolver.go 2 73.58%
common/task/parallelTaskProcessor.go 2 92.48%
service/history/execution/mutable_state_builder.go 2 69.87%
service/matching/taskListManager.go 2 74.09%
common/cache/lru.go 3 90.73%
common/task/fifoTaskScheduler.go 5 84.54%
Totals Coverage Status
Change from base Build 26288857-7c8e-4894-b84e-d2591c5fd45b: 0.07%
Covered Lines: 90369
Relevant Lines: 151205
💛 - Coveralls

@yycptt yycptt merged commit 17663af into cadence-workflow:master Jul 2, 2021
@yycptt yycptt deleted the drop-task-domain-tag branch July 2, 2021 21:34
yycptt added a commit that referenced this pull request Jul 6, 2021
@yycptt
Add domain tag for skip task metrics and logs (#4293)
dad87f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demirkayaender demirkayaender demirkayaender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yycptt @coveralls @demirkayaender