Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestChildWorkflowExecution #448

Merged
merged 3 commits into from
Dec 7, 2017
Merged

Fix flaky TestChildWorkflowExecution #448

merged 3 commits into from
Dec 7, 2017

Conversation

vancexu
Copy link
Contributor

@vancexu vancexu commented Dec 5, 2017

Currently in TestChildWorkflowExecution, ChildWorkflow sometimes complete before poller poll the decision of Parent. This non-deterministic behavior of poller is the root cause of this flask test.

This change create a new tasklist for ChildWorkflow and different pollers poll from the different tasklists, which make poll behavior deterministic.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.233% when pulling aa9baa8 on fixtest into d77fdf2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 66.233% when pulling e64a310 on fixtest into f7e2ff1 on master.

Copy link
Contributor

@madhuravi madhuravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change the experience for our users? Do they always need to use different task lists for parent and child workflows?

@vancexu
Copy link
Contributor Author

vancexu commented Dec 6, 2017

Not really, users can always use one taskList for both parent and child.
The race condition only happens on this integration test.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 66.208% when pulling 23cc380 on fixtest into 7ad6d5b on master.

@vancexu vancexu merged commit 5a5e6ff into master Dec 7, 2017
@vancexu vancexu deleted the fixtest branch December 7, 2017 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants