Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mysql insecure hostname verfiy didn't work #4569

Conversation

git-hulk
Copy link
Contributor

@git-hulk git-hulk commented Oct 14, 2021

What changed?

Fix MySQL insecure hostname verify didn't work

Why?
The MySQL plugin skip this configuration

How did you test it?
Check whether can skip the server name verify or not

Potential risks
No

Release notes
No

Documentation Changes
No

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1ea45965-1095-4c93-aee1-05cf5fac9f3b

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.001%) to 56.814%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/sql/sqlplugin/mysql/plugin.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
common/membership/rpServiceResolver.go 2 73.58%
common/task/fifoTaskScheduler.go 2 87.63%
common/task/weightedRoundRobinTaskScheduler.go 2 88.6%
service/history/queue/timer_queue_processor_base.go 4 78.83%
Totals Coverage Status
Change from base Build 5f69fa03-622b-40d8-a9eb-f129cb92dbef: 0.001%
Covered Lines: 81257
Relevant Lines: 143022

💛 - Coveralls

@longquanzheng longquanzheng merged commit 75b10a5 into cadence-workflow:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants