Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix docker build #479

Merged
merged 1 commit into from
Dec 21, 2017
Merged

bugfix docker build #479

merged 1 commit into from
Dec 21, 2017

Conversation

wxing1292
Copy link
Contributor

No description provided.

@wxing1292 wxing1292 self-assigned this Dec 21, 2017
longquanzheng
longquanzheng reviewed Dec 21, 2017
View reviewed changes
Copy link
Contributor

@longquanzheng longquanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a bug

@wxing1292
Copy link
Contributor Author

wxing1292 commented Dec 21, 2017 •
edited
Loading

I don't think this is a bug

why?
if you try to build a branch and you make a typo in the branch name, docker will continue to build and nobody will understand why the change is not included.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 66.586% when pulling 3ffbc41 on bugfix-docker into 26303d5 on master.

@wxing1292 wxing1292 merged commit 3c1e5bb into master Dec 21, 2017
@wxing1292 wxing1292 deleted the bugfix-docker branch December 21, 2017 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longquanzheng longquanzheng longquanzheng approved these changes

Assignees

@wxing1292 wxing1292

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wxing1292 @coveralls @longquanzheng