Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics to persistence for visibility #486

Merged
merged 3 commits into from
Jan 3, 2018
Merged

Add metrics to persistence for visibility #486

merged 3 commits into from
Jan 3, 2018

Conversation

vancexu
Copy link
Contributor

@vancexu vancexu commented Jan 2, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 66.331% when pulling f95b34a on metric into 36c6f54 on master.

samarabbas
samarabbas approved these changes Jan 2, 2018
View reviewed changes
common/persistence/persistenceMetricClients.go
return response, err
}

func (p *visibilityPersistenceClient) updateErrorMetric(scope int, err error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to handle 'EntityNotExistsError' separately. We don't want to count this error against our SLA.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 66.304% when pulling beba8a5 on metric into 8a89e91 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 66.287% when pulling beba8a5 on metric into 8a89e91 on master.

@vancexu vancexu merged commit bb03ce5 into master Jan 3, 2018
@vancexu vancexu deleted the metric branch January 3, 2018 00:20
@vancexu vancexu mentioned this pull request Jan 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarabbas samarabbas samarabbas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vancexu @coveralls @samarabbas