Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update time to ES visibility requests and records #4962

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

neil-xie
Copy link
Member

What changed?
Added update time field to the workflow execution visibility requests and records, to track the workflows which don't make progress for a while.

Why?

How did you test it?
Tested with elastic search locally, was able to see the records with update time.

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Aug 22, 2022

Pull Request Test Coverage Report for Build 0182eb77-d079-4e22-a2a8-d4f990487ccf

  • 25 of 33 (75.76%) changed or added relevant lines in 10 files are covered.
  • 20 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.2%) to 57.839%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/elasticsearch/client_v7.go 0 3 0.0%
common/types/shared.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
common/membership/hashring.go 2 83.54%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/persistenceMetricClients.go 2 55.17%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/shard/context.go 2 66.52%
service/history/task/transfer_standby_task_executor.go 2 87.21%
common/task/fifoTaskScheduler.go 4 85.57%
service/history/task/fetcher.go 4 91.24%
Totals Coverage Status
Change from base Build 0182dd3a-36c7-4c9b-8d44-409d7ca07b52: 0.2%
Covered Lines: 84455
Relevant Lines: 146017

💛 - Coveralls

Copy link
Contributor

@shijiesheng shijiesheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neil-xie neil-xie merged commit 2bca516 into master Aug 29, 2022
@neil-xie neil-xie deleted the CDNC-2567 branch August 29, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants