Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cadence CLI #5005

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Fix Cadence CLI #5005

merged 1 commit into from
Sep 29, 2022

Conversation

Shaddoll
Copy link
Member

What changed?
Add a new flag for CLI

Why?
To support SQL DB with multiple shards

How did you test it?
manual test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 01838a3c-615b-4a2b-99b6-d3c77bf5415e

  • 4 of 7 (57.14%) changed or added relevant lines in 1 file are covered.
  • 167 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-0.09%) to 57.22%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cli/database.go 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 88.6%
service/history/queue/transfer_queue_processor_base.go 1 77.62%
service/history/execution/mutable_state_builder.go 2 68.63%
service/history/task/transfer_active_task_executor.go 2 72.15%
service/matching/matcher.go 2 91.46%
common/persistence/serialization/parser.go 4 62.41%
common/persistence/serialization/thrift_decoder.go 4 53.06%
common/task/fifoTaskScheduler.go 4 82.47%
service/history/task/fetcher.go 4 91.24%
common/cache/lru.go 5 90.73%
Totals Coverage Status
Change from base Build 01837e07-4f5c-45fa-bc7e-c21cfae9b732: -0.09%
Covered Lines: 85069
Relevant Lines: 148669

💛 - Coveralls

@Shaddoll Shaddoll merged commit 832f71a into cadence-workflow:master Sep 29, 2022
Groxx pushed a commit that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants