Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused code #5024

Conversation

vytautas-karpavicius
Copy link
Contributor

What changed?
Removed common/locks/idMutex and its tests.

Why?
Not used anywhere.

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 01846164-56ac-44d8-88f5-6d95b95998eb

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 67 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.02%) to 57.302%

Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
common/types/shared.go 1 41.66%
common/task/fifoTaskScheduler.go 2 87.63%
service/history/task/transfer_active_task_executor.go 2 72.15%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 59.1%
service/matching/taskListManager.go 3 76.37%
common/types/mapper/thrift/shared.go 4 63.15%
service/history/task/fetcher.go 4 91.24%
service/history/task/transfer_standby_task_executor.go 4 85.98%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 14 79.16%
Totals Coverage Status
Change from base Build 01845b92-dbad-46b5-bd33-228a5c801612: -0.02%
Covered Lines: 85114
Relevant Lines: 148537

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius requested a review from a team November 10, 2022 12:21
@vytautas-karpavicius vytautas-karpavicius marked this pull request as ready for review November 10, 2022 12:21
@vytautas-karpavicius vytautas-karpavicius merged commit 0c8e16c into cadence-workflow:master Nov 10, 2022
@vytautas-karpavicius vytautas-karpavicius deleted the remove-dead-code branch November 10, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants