Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable workflow corruption check for Describe and Query API #5028

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

Shaddoll
Copy link
Member

What changed?
Enable workflow corruption check for Describe and Query API

Why?
To resolve data resurrection issue

How did you test it?
local test on laptop

Potential risks
low risk, because it is wrapped with a feature flag (off by default)

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 0184884a-0735-4415-ab88-5d558ca3294a

  • 4 of 10 (40.0%) changed or added relevant lines in 1 file are covered.
  • 71 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.008%) to 57.296%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/historyEngine.go 4 10 40.0%
Files with Coverage Reduction New Missed Lines %
common/types/shared.go 1 41.66%
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
service/history/task/transfer_active_task_executor.go 2 72.15%
common/persistence/persistenceMetricClients.go 2 55.45%
service/history/handler.go 2 47.17%
common/persistence/statsComputer.go 2 94.64%
common/cache/lru.go 2 92.2%
client/history/client.go 2 38.1%
common/persistence/executionManager.go 2 78.83%
client/history/metricClient.go 2 45.3%
Totals Coverage Status
Change from base Build 018484c6-c8b6-4f6b-8227-73048ca9ba0c: 0.008%
Covered Lines: 85126
Relevant Lines: 148573

💛 - Coveralls

Copy link
Contributor

@mindaugasbarcauskas mindaugasbarcauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Shaddoll Shaddoll merged commit 1a50671 into cadence-workflow:master Nov 18, 2022
@Shaddoll Shaddoll deleted the corrupt-check branch November 18, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants