Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parent close policy to terminate/cancel child workflows even after continue as new #5032

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Nov 24, 2022

What changed?
this picks temporalio/temporal#696
and partially picks temporalio/temporal#365

Why?
see the 2 cherry picks

How did you test it?
Tested by terminating childworkflow

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll changed the title [WIP]Update parent close policy to terminate/cancel child workflows even after continue as new Update parent close policy to terminate/cancel child workflows even after continue as new Nov 28, 2022
@Shaddoll Shaddoll force-pushed the fix-parent-close-policy branch from f46cf82 to 206d92f Compare November 28, 2022 18:04
@Shaddoll Shaddoll force-pushed the fix-parent-close-policy branch from 206d92f to 84bed36 Compare November 28, 2022 18:20
@coveralls
Copy link

Pull Request Test Coverage Report for Build 0184bf78-5739-40a2-b514-281ebfd1fbfc

  • 76 of 106 (71.7%) changed or added relevant lines in 6 files are covered.
  • 76 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 57.284%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/types/shared.go 8 10 80.0%
service/worker/parentclosepolicy/workflow.go 0 5 0.0%
service/history/historyEngine.go 14 37 37.84%
Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_builder.go 2 68.79%
service/history/task/transfer_standby_task_executor.go 2 87.24%
common/util.go 2 52.54%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/matching/taskListManager.go 3 76.37%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 60.0%
common/task/fifoTaskScheduler.go 4 80.41%
service/history/execution/mutable_state_task_refresher.go 7 62.34%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 19 86.13%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 32 74.27%
Totals Coverage Status
Change from base Build 0184a65d-80f0-4061-b094-4c25418ca876: 0.02%
Covered Lines: 85173
Relevant Lines: 148685

💛 - Coveralls

Copy link
Contributor

@mindaugasbarcauskas mindaugasbarcauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Shaddoll Shaddoll merged commit 477c65b into cadence-workflow:master Nov 28, 2022
@Shaddoll Shaddoll deleted the fix-parent-close-policy branch November 28, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants