Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects interface #5049

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Corrects interface #5049

merged 2 commits into from
Dec 13, 2022

Conversation

davidporter-id-au
Copy link
Member

Corrects private interfaces which were exposed in #5046.

Because they're private, it's not possible to mock this function (🤦 ). This corrects this oversight.

Unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 01850d26-99b1-41c2-ad98-b21dff0127be

  • 2 of 6 (33.33%) changed or added relevant lines in 1 file are covered.
  • 41 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.02%) to 57.262%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cassandra/cqlclient.go 2 6 33.33%
Files with Coverage Reduction New Missed Lines %
service/history/queue/transfer_queue_processor_base.go 1 77.62%
client/history/client.go 2 38.1%
client/history/metricClient.go 2 45.3%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/fifoTaskScheduler.go 2 87.63%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_builder.go 2 68.79%
service/history/handler.go 2 47.15%
service/matching/matcher.go 2 91.46%
service/matching/taskListManager.go 3 76.37%
Totals Coverage Status
Change from base Build 01850ad2-b69e-4be1-955e-0b7b658eaf18: 0.02%
Covered Lines: 85171
Relevant Lines: 148739

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants