Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize SQL layer supporting batch delete #5053

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

Shaddoll
Copy link
Member

What changed?
pick temporalio/temporal#982

Why?
see temporalio/temporal#982

How did you test it?
persistence test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 01851d54-36c6-46ad-8bdd-e5e282d6b8fc

  • 76 of 100 (76.0%) changed or added relevant lines in 4 files are covered.
  • 83 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.01%) to 57.256%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/sql/sqlplugin/mysql/execution_maps.go 24 36 66.67%
common/persistence/sql/sqlplugin/postgres/execution_maps.go 24 36 66.67%
Files with Coverage Reduction New Missed Lines %
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/shard/context.go 2 66.52%
service/history/task/transfer_standby_task_executor.go 2 86.4%
common/persistence/statsComputer.go 3 94.64%
common/task/fifoTaskScheduler.go 3 82.47%
common/persistence/serialization/parser.go 4 63.91%
common/persistence/serialization/thrift_decoder.go 4 57.14%
service/history/queue/timer_queue_processor_base.go 4 77.48%
service/history/task/fetcher.go 4 91.24%
Totals Coverage Status
Change from base Build 018513a5-6a33-488d-a5ae-9046c61d2609: 0.01%
Covered Lines: 85183
Relevant Lines: 148775

💛 - Coveralls

@Shaddoll Shaddoll merged commit 29398d8 into cadence-workflow:master Dec 20, 2022
@Shaddoll Shaddoll deleted the batch-delete branch December 20, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants