Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete uninitialized workflow execution record if workflow failed to start #5059

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

neil-xie
Copy link
Member

What changed?
Added new delete uninitialized workflow execution method
If workflow failed to start, delete the record. We only need to keep the records for the stuck workflows

Why?

How did you test it?
Tested locally

Potential risks

Release notes

Documentation Changes

@allenchen2244
Copy link
Contributor

Anyway to test on staging? Otherwise LGTM

@neil-xie
Copy link
Member Author

Anyway to test on staging? Otherwise LGTM

Yeah, I can test with staging2 next week.

@coveralls
Copy link

coveralls commented Dec 29, 2022

Pull Request Test Coverage Report for Build 01858832-3c1b-49c7-adff-5a207e2e5e7a

  • 0 of 91 (0.0%) changed or added relevant lines in 11 files are covered.
  • 96 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.02%) to 57.164%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/visibilitySamplingClient.go 0 3 0.0%
common/persistence/visibilitySingleManager.go 0 3 0.0%
common/persistence/nosql/nosqlVisibilityStore.go 0 4 0.0%
common/persistence/sql/sqlVisibilityStore.go 0 4 0.0%
common/persistence/persistenceMetricClients.go 0 5 0.0%
common/persistence/persistenceRateLimitedClients.go 0 5 0.0%
common/persistence/visibilityDualManager.go 0 9 0.0%
service/history/historyEngine.go 0 11 0.0%
common/persistence/elasticsearch/esVisibilityMetricClients.go 0 12 0.0%
common/persistence/elasticsearch/esVisibilityStore.go 0 17 0.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/executionManager.go 2 78.89%
common/persistence/statsComputer.go 2 94.64%
common/task/fifoTaskScheduler.go 2 87.63%
service/history/task/transfer_active_task_executor.go 2 72.22%
service/matching/matcher.go 2 91.46%
service/matching/taskListManager.go 2 77.11%
common/persistence/serialization/parser.go 4 62.41%
common/persistence/serialization/thrift_decoder.go 4 53.06%
common/persistence/sql/workflowStateMaps.go 8 81.25%
service/history/shard/context.go 9 66.7%
Totals Coverage Status
Change from base Build 01857a77-c095-4358-b8fe-5a82b9321ebf: -0.02%
Covered Lines: 84875
Relevant Lines: 148477

💛 - Coveralls

@neil-xie neil-xie merged commit 933fb08 into master Jan 6, 2023
@neil-xie neil-xie deleted the CDNC-3984 branch January 6, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants