Fix docker image builds with an actually-reliable dependency skip #5071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly this is so obvious in retrospect that I don't know why I tried to do the fake-codegen thing.
The easiest way to skip dependencies is... to not declare that dependency in the first place.
Our github actions to release a new docker image are failing with errors like
which comes from at least two things:
make copyright [stuff that depends on copyright]
doesn't make sense with Make. Order isn't guaranteed like that, and the newly-invalidated tree of dependencies may not be noticed. So that's bad.make .fake-codegen
didn't work anyway, because Make noticed other dependencies of lint/codegen/etc were still missing, and it started building them.The fix is pretty obvious - don't bother trying to
touch
all the dependencies, just remove the dependency.This way it trivially does what we want: just calls
go build
a bunch, without making any changes to files.When merged, I'll cherry-pick this over to the 0.25.x branch so we can do a release there.