Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MigrationChecker interface to expose migration CLI #5424

Merged
merged 4 commits into from
Oct 19, 2023
Merged

MigrationChecker interface to expose migration CLI #5424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45d23f7
added interface to expose migration CLI outside
abhishekj720 Oct 17, 2023
d13228f
added interface to expose migration CLI outside
abhishekj720 Oct 17, 2023
db8368f
naming change
abhishekj720 Oct 17, 2023
8d05b6c
Merge branch 'master' into metadata-fix
abhishekj720 Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/cli/domain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func newDomainCommands() []cli.Command {
Usage: "Migrate existing domain to new domain. This command only validates the settings. It does not perform actual data migration",
Flags: migrateDomainFlags,
Action: func(c *cli.Context) {
newDomainMigrationCLIImpl(c).Validation(c)
NewDomainMigrationCommand(c).Validation(c)
},
},
}
Expand Down
37 changes: 25 additions & 12 deletions tools/cli/domainMigrationCommand.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,15 @@ var (
}
)

type domainMigrationCLIImpl struct {
frontendClient, destinationClient frontend.Client
frontendAdminClient, destinationAdminClient admin.Client
type DomainMigrationCommand interface {
Validation(c *cli.Context)
DomainMetaDataCheck(c *cli.Context) DomainMigrationRow
DomainWorkFlowCheck(c *cli.Context) DomainMigrationRow
SearchAttributesChecker(c *cli.Context) DomainMigrationRow
DynamicConfigCheck(c *cli.Context) DomainMigrationRow
}

func newDomainMigrationCLIImpl(c *cli.Context) *domainMigrationCLIImpl {
func (d *domainMigrationCLIImpl) NewDomainMigrationCLIImpl(c *cli.Context) *domainMigrationCLIImpl {
return &domainMigrationCLIImpl{
frontendClient: cFactory.ServerFrontendClient(c),
destinationClient: cFactory.ServerFrontendClientForMigration(c),
Expand All @@ -123,12 +126,22 @@ func newDomainMigrationCLIImpl(c *cli.Context) *domainMigrationCLIImpl {
}
}

// Export a function to create an instance of the domainMigrationCLIImpl.
func NewDomainMigrationCommand(c *cli.Context) DomainMigrationCommand {
return &domainMigrationCLIImpl{}
}

type domainMigrationCLIImpl struct {
frontendClient, destinationClient frontend.Client
frontendAdminClient, destinationAdminClient admin.Client
}

func (d *domainMigrationCLIImpl) Validation(c *cli.Context) {
checkers := []func(*cli.Context) DomainMigrationRow{
d.migrationDomainMetaDataCheck,
d.migrationDomainWorkFlowCheck,
d.migrationDynamicConfigCheck,
d.searchAttributesChecker,
d.DomainMetaDataCheck,
d.DomainWorkFlowCheck,
d.DynamicConfigCheck,
d.SearchAttributesChecker,
}
wg := &sync.WaitGroup{}
results := make([]DomainMigrationRow, len(checkers))
Expand All @@ -153,7 +166,7 @@ func (d *domainMigrationCLIImpl) Validation(c *cli.Context) {
}
}

func (d *domainMigrationCLIImpl) migrationDomainMetaDataCheck(c *cli.Context) DomainMigrationRow {
func (d *domainMigrationCLIImpl) DomainMetaDataCheck(c *cli.Context) DomainMigrationRow {
domain := c.GlobalString(FlagDomain)
newDomain := c.String(FlagDestinationDomain)
ctx, cancel := newContext(c)
Expand Down Expand Up @@ -194,7 +207,7 @@ func metaDataValidation(currResp *types.DescribeDomainResponse, newResp *types.D
return true, ""
}

func (d *domainMigrationCLIImpl) migrationDomainWorkFlowCheck(c *cli.Context) DomainMigrationRow {
func (d *domainMigrationCLIImpl) DomainWorkFlowCheck(c *cli.Context) DomainMigrationRow {
countWorkFlows := d.countLongRunningWorkflow(c)
check := countWorkFlows == 0
return DomainMigrationRow{
Expand Down Expand Up @@ -222,7 +235,7 @@ func (d *domainMigrationCLIImpl) countLongRunningWorkflow(c *cli.Context) int {
return int(response.GetCount())
}

func (d *domainMigrationCLIImpl) searchAttributesChecker(c *cli.Context) DomainMigrationRow {
func (d *domainMigrationCLIImpl) SearchAttributesChecker(c *cli.Context) DomainMigrationRow {
ctx, cancel := newContext(c)
defer cancel()

Expand Down Expand Up @@ -307,7 +320,7 @@ func findMissingAttributes(requiredAttributes map[string]types.IndexedValueType,
return missingAttributes
}

func (d *domainMigrationCLIImpl) migrationDynamicConfigCheck(c *cli.Context) DomainMigrationRow {
func (d *domainMigrationCLIImpl) DynamicConfigCheck(c *cli.Context) DomainMigrationRow {
var mismatchedConfigs []MismatchedDynamicConfig
check := true

Expand Down