Update github action for image publishing to released #5460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sankari165
approved these changes
Nov 23, 2023
3vilhamster
force-pushed
the
publish-image-on-release
branch
from
cb06299
to
8e7c99b
Compare
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I updated event that is trigering image publication to subscribe to released event instead of published.
Published is triggered for both prerelease and release and we want to publish images only for releases.
See the docs https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=released#release
Why
When we've introduced new process for release process with prereleases we've broke image publication and were publishing images manually.
Should resolve #5416 and #5434
Release notes
Fixed image publication on release.