Unify cassandra setup in docker-compose #5482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… docker-compose files
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Groxx
approved these changes
Dec 17, 2023
taylanisikdemir
approved these changes
Dec 18, 2023
| @@ -3,10 +3,18 @@ version: "3.5" | |||
| services: | |||
| cassandra: | |||
| image: cassandra:4.1.3 | |||
| environment: | |||
| - "MAX_HEAP_SIZE=256M" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I've set limits for java heap size to shrink cassandra memmory allocation.
Also, unified all cassandra images in docker-compose files with the same values for heap, healthchecks and depends_on
Why?
To have a sane and unified way to run minimal local/ci cassandra setup.
How did you test it?
Local docker-compose up and local docker/buildkite run
Potential risks
Release notes
Documentation Changes