Fix README for cassandra tool #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhuravi
reviewed
Feb 9, 2018
tools/cassandra/README.md
Outdated
| @@ -6,19 +6,26 @@ How | |||
| --- | |||
| - Run make bins | |||
| - You should see an executable `cadence-cassandra-tool` | |||
| - Make sure you already created cadence and visibility keyspaces (see `keyspace.cql` in schema) | |||
|
|
|||
| Setting up initial cassandra schema on a new cluster | |||
| ---------------------------------------------------- | |||
| ``` | |||
| ./cadence-cassandra-tool -ep 127.0.0.1 -k cadence setup-schema -v 0.0 -- this sets up just the schema version tables with initial version of 0.0 | |||
There was a problem hiding this comment.
There is a make target for this. You can just replace these with
make install-schema
madhuravi
reviewed
Feb 9, 2018
tools/cassandra/README.md
Outdated
| @@ -6,19 +6,26 @@ How | |||
| --- | |||
| - Run make bins | |||
| - You should see an executable `cadence-cassandra-tool` | |||
| - Make sure you already created cadence and visibility keyspaces (see `keyspace.cql` in schema) | |||
There was a problem hiding this comment.
This is a bit confusing. Aren't we creating this using the commands below? How will the user make sure they have already created the keyspaces.
madhuravi
reviewed
Feb 9, 2018
| make install-schema | ||
| ``` | ||
|
|
||
| Setting up schema on a new cluster manually |
There was a problem hiding this comment.
I don't think this section is necessary If folks want to dig in, they can easily look up Makefile to see command breakdown.
There was a problem hiding this comment.
Never mind, I see this is a repo for tools. Ignore this.
madhuravi
reviewed
Feb 9, 2018
tools/cassandra/README.md
Outdated
| @@ -7,18 +7,30 @@ How | |||
| - Run make bins | |||
| - You should see an executable `cadence-cassandra-tool` | |||
|
|
|||
| Setting up initial cassandra schema on a new cluster | |||
| Setting up cassandra schema on a new cluster using Makefile | |||
There was a problem hiding this comment.
Can avoid "using Makefile". It's a bit confusing, Instead, you call it out as a shortcut.
madhuravi
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.