Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing exclude-query support to list-workflows on the CLI #5583

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

Groxx
Copy link
Member

@Groxx Groxx commented Jan 8, 2024

I'm not really sure why this got missed when they're right next to each other,
But it looks pretty easy to support.


Tested with --pagesize, --more, etc and it all seems fine. Code looks like it's probably pretty straightforwardly supported too.

I'm not really sure why this got missed when they're right next to each other,
But it looks pretty easy to support.
@coveralls
Copy link

coveralls commented Jan 8, 2024

Pull Request Test Coverage Report for Build 018ceae7-a26e-4d30-8405-ff668e45923c

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 62.272%

Totals Coverage Status
Change from base Build 018cead3-4b13-44cd-ab64-3d5b5d175cab: -0.04%
Covered Lines: 93379
Relevant Lines: 149954

💛 - Coveralls

@Groxx Groxx merged commit 08547a2 into cadence-workflow:master Jan 8, 2024
16 checks passed
@Groxx Groxx deleted the list-with-excluded branch January 8, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants