Put a timeout for timer task deletion loop during shutdown #5626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
| @@ -365,7 +375,7 @@ func (t *timerQueueProcessor) completeTimerLoop() { | |||
| return | |||
| case <-completeTimer.C: | |||
| for attempt := 0; attempt < t.config.TimerProcessorCompleteTimerFailureRetryCount(); attempt++ { | |||
| err := t.completeTimer() | |||
| err := t.completeTimer(context.Background()) | |||
There was a problem hiding this comment.
I wonder if this should be unbounded, this is strictly better however.
There was a problem hiding this comment.
I debated on this but leaving it as is for now to limit the changes to be tested in actual deployment
davidporter-id-au
approved these changes
Jan 24, 2024
Pull Request Test Coverage Report for Build 018d3d8b-6e10-4d6d-88cf-9cc97fe07601
💛 - Coveralls |
taylanisikdemir
force-pushed
the
taylan/timer_task_deletion_timeout
branch
from
245f38b
to
bec3a33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Timer queue processor has a loop to delete tasks batch by batch periodically and also during shut down. It just uses background context so it can take a long time in theory.
For shut down scenario adding a timeout to make sure it doesn't hang the process when there's a lot of tasks to delete.
Why?
Respect shut down signals to make rollouts/restarts more smooth.
How did you test it?
Will test in a staging environment. Changes are behind a dynamic config.