Emit metrics when transfer tasks could be ratelimited #5652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sankari165
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
jakobht
approved these changes
Feb 9, 2024
Pull Request Test Coverage Report for Build 018d8e6b-9771-49d7-b2ee-9f71a53ac1b3
💛 - Coveralls |
| @@ -99,6 +103,9 @@ func (t *transferTaskExecutorBase) pushActivity( | |||
| t.logger.Fatal("Cannot process non activity task", tag.TaskType(task.GetTaskType())) | |||
| } | |||
|
|
|||
| // Ratelimiting is not done. This is only to count the number of requests via metrics | |||
| t.wfIDCache.AllowInternal(task.DomainID, task.WorkflowID) | |||
There was a problem hiding this comment.
This function is called by transfer active task executor and transfer standby task executor. Are we going to count those together in same rate limit quota?
There was a problem hiding this comment.
Thats a good catch. I have considered to address this in a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding call to workflowID cache based ratelimiter during transfer task execution
Why?
to get metrics on potential hot shards and investigate when requests will be ratelimited
How did you test it?
tested locally and added unit tests
Potential risks
Release notes
Documentation Changes