Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit metrics when transfer tasks for decisions could be ratelimited #5665

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

sankari165
Copy link
Member

What changed?
Adding call to workflowID cache based ratelimiter during transfer task execution for decisions

Why?
to get metrics on potential hot shards and investigate when requests will be ratelimited

How did you test it?
local and unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018dac5a-226c-4556-9bd9-8c2e78309708

Details

  • 0 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 72 unchanged lines in 18 files lost coverage.
  • Overall coverage increased (+0.008%) to 62.766%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
common/persistence/sql/common.go 2 72.73%
common/persistence/sql/sqlplugin/mysql/db.go 2 83.33%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/task/parallel_task_processor.go 2 93.06%
service/frontend/api/handler.go 2 62.05%
service/history/execution/mutable_state_builder.go 2 68.64%
service/history/task/transfer_active_task_executor.go 2 72.38%
service/matching/db.go 2 73.23%
common/log/tag/tags.go 3 50.18%
Totals Coverage Status
Change from base Build 018da942-56f6-44e4-a3d5-d6f2d0cd6fc6: 0.008%
Covered Lines: 92638
Relevant Lines: 147592

💛 - Coveralls

@sankari165 sankari165 merged commit 8d41945 into cadence-workflow:master Feb 15, 2024
16 checks passed
@sankari165 sankari165 deleted the CDNC-6884 branch February 15, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants