Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the build-changed message failure #5667

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Groxx
Copy link
Member

@Groxx Groxx commented Feb 15, 2024

make tidy isn't mentioned, and the command/checks weren't even in the right order anyway.

We should probably streamline pre-test PR checks anyway, but fixing the message is a clear improvement.

Comment on lines +7 to 8
make copyright
make fmt
Copy link
Member Author

@Groxx Groxx Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmt will fail if copyright is not up to date, so there's not really any point in fmt-then-copyright.

(I keep thinking I should make fmt just auto-add copyright... not really sure why it didn't originally, but I just haven't bothered looking yet)

@Groxx Groxx enabled auto-merge (squash) February 16, 2024 00:08
@Groxx Groxx merged commit 02dbcd6 into cadence-workflow:master Feb 16, 2024
16 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018daf2e-5b3b-491a-8168-160f7823bd76

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 54 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.01%) to 62.69%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 88.06%
common/persistence/sql/sqlplugin/postgres/db.go 2 85.0%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/util.go 2 91.69%
service/frontend/api/handler.go 2 62.17%
service/history/execution/mutable_state_task_refresher.go 3 56.65%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/frontend/wrappers/metered/metered.go 4 65.5%
common/task/fifo_task_scheduler.go 5 82.47%
common/persistence/statsComputer.go 6 93.57%
Totals Coverage Status
Change from base Build 018daf26-1ed2-438a-a7c4-69fb889bbcbc: -0.01%
Covered Lines: 92544
Relevant Lines: 147622

💛 - Coveralls

@Groxx Groxx deleted the minor-golint branch February 16, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants