Fix SignalWithStartWorkflow Api #5671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 018dd21e-5b88-4d12-91ee-7c05d5340b28Details
💛 - Coveralls |
service/history/historyEngine.go
Outdated
| @@ -2584,6 +2584,10 @@ func (e *historyEngineImpl) SignalWithStartWorkflowExecution( | |||
| return nil, workflow.ErrSignalsLimitExceeded | |||
| } | |||
|
|
|||
| if requestID := sRequest.GetRequestID(); requestID != "" { | |||
There was a problem hiding this comment.
How did you notice this was missing? It's a little bit unclear to me what are the side effects of doing this here. There's already AddWorkflowExecutionSignaled below, do these get deduped somehow?
It would be great if we take this opportunity to add some extra documentation/diagram for SignalWithStart flow.
There was a problem hiding this comment.
I tested it locally and found it's not idempotent in this case.
Shaddoll
force-pushed
the
signalwithstart
branch
from
ac9198a
to
1413ab9
Compare
taylanisikdemir
approved these changes
Feb 22, 2024
| @@ -2584,6 +2584,10 @@ func (e *historyEngineImpl) SignalWithStartWorkflowExecution( | |||
| return nil, workflow.ErrSignalsLimitExceeded | |||
| } | |||
|
|
|||
| if requestID := sRequest.GetRequestID(); requestID != "" { | |||
There was a problem hiding this comment.
I mean, pretty amazingly big fix, nice find. Is this flow covered with a unit-test? If they're not, I think we ought to probably cover all write (+query) APIs to ensure they're idempotent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Store request ID to mutable state when handling signalwithstart request
Why?
To make SignalWithStartWorkflow idempotent
How did you test it?
manual test
Potential risks
Release notes
Documentation Changes