Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context leak in pinot integration test #5682

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

neil-xie
Copy link
Member

What changed?
Fix context leak in pinot integration test
Context leak was fixed in #5377, but pinot integration test is missed.

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 018dd1bf-9ff9-4b77-9158-bd99bd26af44

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 95 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-0.03%) to 62.754%

Files with Coverage Reduction New Missed Lines %
common/persistence/sql/common.go 2 72.73%
common/persistence/sql/sqlplugin/mysql/db.go 2 83.33%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
service/history/task/transfer_active_task_executor.go 2 72.38%
service/history/task/transfer_standby_task_executor.go 2 86.6%
service/matching/db.go 2 73.23%
common/log/tag/tags.go 3 50.18%
service/history/execution/mutable_state_task_refresher.go 3 58.86%
service/history/queue/timer_queue_processor_base.go 3 77.82%
Totals Coverage Status
Change from base Build 018dd1a9-2e9f-4a05-80b0-faec19a35f2d: -0.03%
Covered Lines: 92750
Relevant Lines: 147800

💛 - Coveralls

@neil-xie neil-xie merged commit 9a1c2ed into cadence-workflow:master Feb 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants