Write tests for cdb.SelectCurrentWorkflow #5693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylanisikdemir
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx and
demirkayaender
as code owners
Pull Request Test Coverage Report for Build 018df712-b5da-43f8-ab44-aafa2edda07cDetails
💛 - Coveralls |
Shaddoll
approved these changes
Feb 29, 2024
taylanisikdemir
force-pushed
the
taylan/select_current_wf_test
branch
from
e152fdf
to
ece486f
Compare
taylanisikdemir
merged commit 48e9c04
into
cadence-workflow:master
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR covers
SelectCurrentWorkflowwithout going too deep intoparseWorkflowExecutionInfohelper function. It will be covered separately with a dedicated test function.Why?
Increase coverage.