remove old metrics wrappers and use new generated metered wrappers #5717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Switched to generated metered wrappers.
Previously, I've introduced metered wrappers for all persistence managers and verified that the behavior of these methods didn't change.
So it is safe to switch to them and remove the old untested file.
Why?
Improve test coverage and remove unused code.
How did you test it?
Unit tests to ensure that behaviour is the same between old metered clients and new one.
Potential risks
Logs/metrics could be affected, though with unit tests it is very unlikely.
Release notes
Documentation Changes