Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for PrepareResetWorkflowExecutionRequestWithMapsAndE… #5731

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

agautam478
Copy link
Contributor

@agautam478 agautam478 commented Mar 6, 2024

What changed?

  • Added 2 unit tests for PrepareResetWorkflowExecutionRequestWithMapsAndEventBuffer.
  • 2 more cases for PrepareCreateWorkflowExecutionRequestWithMaps

Why?
As a part of the code coverage initiative.

How did you test it?
unit test

Potential risks
NA

Release notes

Documentation Changes

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Merging #5731 (84d5706) into master (8f5bc04) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 84d5706 differs from pull request most recent head d042752. Consider uploading reports for the commit d042752 to get more accurate results

Additional details and impacted files

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f5bc04...d042752. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 6, 2024

Pull Request Test Coverage Report for Build 018e15bc-8b29-472d-8c66-4ef5fd2f5c54

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 94 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-0.03%) to 63.76%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 77.62%
common/peerprovider/ringpopprovider/config.go 2 81.58%
common/persistence/historyManager.go 2 66.67%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
common/task/fifo_task_scheduler.go 2 87.63%
common/util.go 2 91.69%
service/history/task/transfer_standby_task_executor.go 2 86.6%
service/matching/db.go 2 73.23%
service/matching/taskListManager.go 2 80.46%
Totals Coverage Status
Change from base Build 018e15b1-565e-4c2c-a376-65763e1f756a: -0.03%
Covered Lines: 93472
Relevant Lines: 146599

💛 - Coveralls

@agautam478 agautam478 enabled auto-merge (squash) March 6, 2024 21:09
@agautam478 agautam478 merged commit d8b209f into cadence-workflow:master Mar 6, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants