Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very minor nil-or-empty cleanup #5745

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Very minor nil-or-empty cleanup #5745

merged 3 commits into from
Mar 7, 2024

Conversation

Groxx
Copy link
Contributor

@Groxx Groxx commented Mar 6, 2024

Just randomly exploring, found with

❯ sg run --pattern '$X == nil || len($X) == 0'
./common/dynamicconfig/configstore/config_store_client.go
413│	if dcValues == nil || len(dcValues) == 0 {

This is clearly a no-op change. All nil slices are zero-length.

@coveralls
Copy link

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 018e175b-2d68-4bd4-904e-7921752f5e0d

Details

  • 11 of 13 (84.62%) changed or added relevant lines in 1 file are covered.
  • 71 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.009%) to 63.895%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/dynamicconfig/configstore/config_store_client.go 11 13 84.62%
Files with Coverage Reduction New Missed Lines %
service/history/task/transfer_active_task_executor.go 2 72.38%
service/matching/taskListManager.go 2 80.46%
service/history/task/transfer_standby_task_executor.go 2 87.42%
service/matching/taskReader.go 2 84.88%
service/history/execution/mutable_state_util.go 2 78.48%
common/persistence/statsComputer.go 3 94.64%
service/history/task/fetcher.go 4 85.05%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 6 63.03%
service/history/execution/mutable_state_task_refresher.go 14 60.44%
common/persistence/nosql/nosqlplugin/cassandra/workflow_parsing_utils.go 34 79.13%
Totals Coverage Status
Change from base Build 018e1703-751e-4216-8e8c-7d9ec8ca044b: -0.009%
Covered Lines: 93670
Relevant Lines: 146599

💛 - Coveralls

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #5745 (721c4e2) into master (b34ee0b) will decrease coverage by 0.47%.
The diff coverage is 100.00%.

❗ Current head 721c4e2 differs from pull request most recent head a346ccf. Consider uploading reports for the commit a346ccf to get more accurate results

Additional details and impacted files
Files Coverage Δ
...n/dynamicconfig/configstore/config_store_client.go 63.59% <100.00%> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34ee0b...a346ccf. Read the comment docs.

@Groxx Groxx enabled auto-merge (squash) March 7, 2024 05:21
@Groxx Groxx merged commit 9526e4b into cadence-workflow:master Mar 7, 2024
16 of 18 checks passed
@Groxx Groxx deleted the minor branch March 7, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants