Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config changes to start replicator for standby cluster #575

Merged
merged 2 commits into from
Feb 23, 2018
Merged

Config changes to start replicator for standby cluster #575

merged 2 commits into from
Feb 23, 2018

Conversation

samarabbas
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Feb 22, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 67.509% when pulling a8a9407 on samarabbas:replicator-fixes into ad78f5f on uber:master.

wxing1292
wxing1292 reviewed Feb 22, 2018
View reviewed changes
config/development_standby.yaml Outdated
hostPort: "127.0.0.1:8125"
prefix: "cadence_standby"
pprof:
port: 7941
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 8941

Copy link
Contributor Author

@samarabbas samarabbas Feb 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@samarabbas samarabbas merged commit 095fbd7 into cadence-workflow:master Feb 23, 2018
@samarabbas samarabbas deleted the replicator-fixes branch February 23, 2018 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxing1292 wxing1292 wxing1292 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samarabbas @coveralls @wxing1292