-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional tests for ExecutionManager #5809
Merged
3vilhamster
merged 5 commits into
cadence-workflow:master
from
3vilhamster:execution-manager-tests
Mar 25, 2024
Merged
Add additional tests for ExecutionManager #5809
3vilhamster
merged 5 commits into
cadence-workflow:master
from
3vilhamster:execution-manager-tests
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
March 21, 2024 21:45
Pull Request Test Coverage Report for Build 018e759f-f52b-4536-86e5-067b10a27c55Details
💛 - Coveralls |
Codecov Report
Additional details and impacted files
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
taylanisikdemir
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding more tests to ExecutionManager.
Now covering GetExecutionInfo and UpdateExecution.
That includes a lot of deserialization and data conversion. I've added some sane checks, if we'll spot any missing fields, it should be easy enough extend the test with extra fields.
Why?
Improving code coverage.
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes