Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tests for ExecutionManager #5809

Merged

Conversation

3vilhamster
Copy link
Contributor

What changed?
Adding more tests to ExecutionManager.
Now covering GetExecutionInfo and UpdateExecution.
That includes a lot of deserialization and data conversion. I've added some sane checks, if we'll spot any missing fields, it should be easy enough extend the test with extra fields.

Why?
Improving code coverage.

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Mar 22, 2024

Pull Request Test Coverage Report for Build 018e759f-f52b-4536-86e5-067b10a27c55

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 88 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.02%) to 65.187%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 88.06%
service/history/task/transfer_standby_task_executor.go 2 87.01%
service/history/shard/context.go 2 67.47%
service/matching/db.go 2 73.23%
common/persistence/historyManager.go 2 66.67%
common/log/tag/tags.go 3 50.18%
service/history/task/fetcher.go 3 85.57%
service/matching/taskListManager.go 4 80.46%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 4 76.09%
common/persistence/nosql/nosql_task_store.go 5 61.95%
Totals Coverage Status
Change from base Build 018e712c-b24b-4404-8d45-a837376600cf: -0.02%
Covered Lines: 95238
Relevant Lines: 146099

💛 - Coveralls

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Merging #5809 (8fcc005) into master (3498c59) will increase coverage by 0.37%.
The diff coverage is 100.00%.

Additional details and impacted files
Files Coverage Δ
common/persistence/execution_manager.go 58.40% <100.00%> (+46.33%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3498c59...8fcc005. Read the comment docs.

@3vilhamster 3vilhamster merged commit 07644ce into cadence-workflow:master Mar 25, 2024
20 checks passed
@3vilhamster 3vilhamster deleted the execution-manager-tests branch March 25, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants