added units test for functions in mapper/thrift/replicator.go

[d-vignesh]

What changed?
Added unit test for function in common/types/mapper/thrift/replicator.go

Why?
Improve code coverage

How did you test it?
local testing with go test.

[codecov]

Codecov Report

Merging #5835 (531cf2b) into master (b28dca3) will increase coverage by 0.24%.
The diff coverage is n/a.

❗ Current head 531cf2b differs from pull request most recent head 6ae6836. Consider uploading reports for the commit 6ae6836 to get more accurate results

Additional details and impacted files

Files	Coverage Δ
common/types/mapper/thrift/replicator.go	96.56% <ø> (+93.89%)	⬆️

... and 8 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28dca3...6ae6836. Read the comment docs.

[coveralls]

Pull Request Test Coverage Report for Build 018eb06e-c4cf-4253-8e83-ab9e5926fa70

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 41 unchanged lines in 12 files lost coverage.
• Overall coverage increased (+0.4%) to 67.179%

---

Files with Coverage Reduction	New Missed Lines	%
common/persistence/sql/sqlplugin/mysql/task.go	2	73.68%
service/matching/db.go	2	73.23%
service/history/execution/mutable_state_builder.go	2	70.28%
service/matching/matcher.go	2	90.72%
common/persistence/sql/sqlplugin/mysql/db.go	2	79.49%
common/log/tag/tags.go	3	50.74%
common/task/fifo_task_scheduler.go	3	84.54%
common/persistence/statsComputer.go	3	96.07%
service/history/task/fetcher.go	3	85.57%
service/history/task/transfer_standby_task_executor.go	4	87.42%

Totals
Change from base Build 018eb05e-a5e5-4ec0-b4c3-a6b9b0eebad2:	0.4%
Covered Lines:	98067
Relevant Lines:	145979

---

💛 - Coveralls

[Groxx]

hmm. I guess this file existing is a decent argument that we do need a random-data factory :\

oh well. additions look reasonable 👍

[Groxx]

some very minor "might be nicer if..." thoughts while reading, but overall 👍 nice and simple, big jump in coverage, thanks!

if you want to make any changes I can hold off on merging, but this looks more than good enough to me as-is.
or I'll just merge for you tomorrow if I don't hear back :)

[Groxx]

a thing we've been kinda trying to shift towards / for minor test-boilerplate improvement, making the test container a map[string] can be convenient:

Suggested change

	testCases := []struct {
	desc string
	input *types.GetDomainReplicationMessagesRequest
	}{
	{
	desc: "non-nil input test",
	input: &testdata.GetDomainReplicationMessagesRequest,
	},
	{
	desc: "empty input test",
	input: &types.GetDomainReplicationMessagesRequest{},
	},
	{
	desc: "nil input test",
	input: nil,
	},
	}
	for _, tc := range testCases {
	t.Run(tc.desc, func(t *testing.T) {
	testCases := map[string]*types.GetDomainReplicationMessagesRequest{
	"non-nil": &testdata.GetDomainReplicationMessagesRequest,
	"empty": &types.GetDomainReplicationMessagesRequest{},
	"nil": nil,
	}
	for name, tc := range testCases {
	t.Run(name, func(t *testing.T) {

we obviously mostly don't do this though, your []struct is overwhelmingly the pattern in these tests, so this is not at all a request to change anything. just an observation for anyone reading / reviewing / etc for future work :)

[d-vignesh]

sure @Groxx will follow the map pattern for future tests.

[Groxx]

Suggested change

	MaxiumuPageSize = int32(5)
	MaximumPageSize = int32(5)

[d-vignesh]

Hi @Groxx, thank you for the review, if things look fine from your end, we can go ahead and merge it.

[Groxx]

Hi @Groxx, thank you for the review, if things look fine from your end, we can go ahead and merge it.

ah, maybe you don't have a merge button after approval.
oh well. I'll do that now :)