Kafka based publisher for replication tasks #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhuravi
reviewed
Feb 27, 2018
| @@ -65,3 +68,16 @@ func (c *kafkaClient) NewConsumer(topicName, consumerName string, concurrency in | |||
| consumer, err := c.client.NewConsumer(consumerConfig) | |||
There was a problem hiding this comment.
Fixing the interface issue with the latest kafka client as part of this?
There was a problem hiding this comment.
I will take care of it in a separate PR.
madhuravi
reviewed
Feb 27, 2018
| @@ -30,6 +32,7 @@ type ( | |||
| kafkaClient struct { | |||
| config *KafkaConfig | |||
| client *kafkaclient.Client | |||
There was a problem hiding this comment.
I think all you need is to glide up and make this a non-pointer
There was a problem hiding this comment.
I will take care of it in a separate PR.
wxing1292
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.