Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for handleDomainUpdateReplicationTask #5852

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

abhishekj720
Copy link
Contributor

What changed?
Added tests for TestHandleDomainUpdateReplicationTask

Why?
As part of code coverage week and making Cadence system more reliable

How did you test it?
Unit Tests

Potential risks
No risks. It is written to avoid future risks.

Release notes
No config or schema updates.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Merging #5852 (9de2af7) into master (77fdf3c) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77fdf3c...9de2af7. Read the comment docs.

Copy link
Contributor

@bowenxia bowenxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhishekj720 abhishekj720 merged commit 9764886 into cadence-workflow:master Apr 3, 2024
20 checks passed
@abhishekj720 abhishekj720 deleted the testqqq3 branch April 4, 2024 02:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018ea5e1-a764-4eac-ae96-232eff99ec85

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.007%) to 65.97%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 1 89.05%
service/history/task/transfer_standby_task_executor.go 2 86.6%
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/persistence/sql/sqlplugin/postgres/db.go 2 80.0%
service/history/task/transfer_active_task_executor.go 2 72.7%
service/history/execution/mutable_state_util.go 2 78.13%
common/task/fifo_task_scheduler.go 3 80.41%
service/history/queue/timer_queue_processor_base.go 3 77.82%
service/history/execution/mutable_state_task_refresher.go 10 57.28%
Totals Coverage Status
Change from base Build 018ea5c4-53c8-4125-a9d5-9b64a6b3ad3a: 0.007%
Covered Lines: 96538
Relevant Lines: 146337

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants