Add addition unit tests and comment out unused code in workflow parsing utils functions #5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omment out part of the function that would never be called.
timl3136
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Codecov Report
Additional details and impacted files
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
taylanisikdemir
approved these changes
Apr 4, 2024
Comment on lines
547
to
555
| // in case CrossClusterTaskDefaultTargetRunID is updated and not equal to TransferTaskTransferTargetRunID | ||
| // if v, ok := result["target_run_id"]; ok { | ||
| // info.TargetRunID = v.(gocql.UUID).String() | ||
| // if info.TargetRunID == persistence.CrossClusterTaskDefaultTargetRunID { | ||
| // info.TargetRunID = "" | ||
| // } | ||
| // } | ||
| // return info | ||
|
|
There was a problem hiding this comment.
let's just remove this. leaving commented code is confusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add more unit tests, also comment out code that will almost never be run
Why?
Improve test coverage and stability
How did you test it?
Unit tests
Potential risks
Release notes
Documentation Changes