Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing logs #5905

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix missing logs #5905

merged 1 commit into from
Apr 12, 2024

Conversation

Shaddoll
Copy link
Contributor

What changed?
Fix missing logs

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll enabled auto-merge (squash) April 11, 2024 22:23
Copy link
Contributor

@davidporter-id-au davidporter-id-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@coveralls
Copy link

coveralls commented Apr 11, 2024

Pull Request Test Coverage Report for Build 018ed001-06c8-4658-842a-52ec262a254a

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.03%) to 67.366%

Files with Coverage Reduction New Missed Lines %
common/task/fifo_task_scheduler.go 2 87.63%
service/matching/taskListManager.go 2 80.96%
service/history/execution/mutable_state_task_refresher.go 10 65.82%
Totals Coverage Status
Change from base Build 018ecf4a-aab3-4595-8b0d-19012809df2b: 0.03%
Covered Lines: 98487
Relevant Lines: 146197

💛 - Coveralls

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Merging #5905 (265e9fc) into master (204d17f) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 265e9fc differs from pull request most recent head aea8ab2. Consider uploading reports for the commit aea8ab2 to get more accurate results

Additional details and impacted files
Files Coverage Δ
service/history/execution/mutable_state_builder.go 41.15% <0.00%> (+0.34%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 204d17f...aea8ab2. Read the comment docs.

@Shaddoll Shaddoll merged commit 5b27da0 into cadence-workflow:master Apr 12, 2024
18 checks passed
@Shaddoll Shaddoll deleted the log branch April 12, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants