Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsDuplicateRequestError function #5914

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

Shaddoll
Copy link
Member

What changed?
add a function for err match

Why?

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll merged commit 86a5454 into cadence-workflow:master Apr 17, 2024
18 checks passed
@Shaddoll Shaddoll deleted the request branch April 17, 2024 19:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018eed7f-7e79-488a-b66f-d014309bdb06

Details

  • 9 of 10 (90.0%) changed or added relevant lines in 2 files are covered.
  • 59 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.02%) to 67.414%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/engine/engineimpl/historyEngine.go 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/task/transfer_active_task_executor.go 2 72.7%
service/matching/matcher.go 2 90.72%
service/history/execution/mutable_state_util.go 2 78.52%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/persistence/historyManager.go 2 66.67%
service/matching/taskListManager.go 3 80.2%
service/history/task/fetcher.go 3 85.57%
service/frontend/wrappers/metered/metered.go 4 66.67%
service/history/task/transfer_standby_task_executor.go 6 87.42%
Totals Coverage Status
Change from base Build 018eeced-315a-46c0-b2fc-ecb9db602faf: -0.02%
Covered Lines: 98673
Relevant Lines: 146368

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants