Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-coverage] Add more tests for HandleDecisionTaskCompleted #5945

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

ketsiambaku
Copy link
Member

@ketsiambaku ketsiambaku commented Apr 26, 2024

What changed?

  1. Remove underscore(_) in variable names as per previous PR comment
  2. Add more test cases for HandleDecisionTaskCompleted

Why?
Improve code coverage in service/history/decision

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

@ketsiambaku ketsiambaku changed the title Add test cases for history decision handler HandleDecisionTaskComplet… [code-coverage] Add more tests for HandleDecisionTaskCompleted Apr 26, 2024
@ketsiambaku ketsiambaku marked this pull request as ready for review April 26, 2024 16:05
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.68%. Comparing base (5494354) to head (9039eed).

Additional details and impacted files

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5494354...9039eed. Read the comment docs.

@ketsiambaku ketsiambaku merged commit 8868545 into cadence-workflow:master Apr 26, 2024
22 checks passed
@ketsiambaku ketsiambaku deleted the history-decision branch April 26, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants