Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for mutable state task refresher #5971

Merged
merged 3 commits into from
May 7, 2024

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented May 6, 2024

What changed?
Add unit tests for mutable state task refresher

Why?
improve coverage

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.20%. Comparing base (2ac145f) to head (5f7f6c0).
Report is 1 commits behind head on master.

❗ Current head 5f7f6c0 differs from pull request most recent head 0fbc282. Consider uploading reports for the commit 0fbc282 to get more accurate results

Additional details and impacted files
Files Coverage Δ
.../history/execution/mutable_state_task_refresher.go 92.59% <100.00%> (+89.81%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abfa99b...0fbc282. Read the comment docs.

@Shaddoll Shaddoll merged commit 2836bf6 into cadence-workflow:master May 7, 2024
18 checks passed
@Shaddoll Shaddoll deleted the refresh branch May 7, 2024 20:47
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f54b1-eea9-4732-b8ae-65a3e24128be

Details

  • 59 of 59 (100.0%) changed or added relevant lines in 1 file are covered.
  • 52 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.08%) to 68.269%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 88.06%
service/history/handler/handler.go 2 60.71%
service/matching/taskListManager.go 2 81.16%
common/asyncworkflow/queue/consumer/default_consumer.go 3 92.13%
common/persistence/statsComputer.go 3 96.79%
common/archiver/filestore/historyArchiver.go 4 80.95%
service/frontend/api/handler.go 6 62.14%
service/history/engine/engineimpl/poll_mutable_state.go 9 74.16%
service/frontend/wrappers/metered/metered.go 9 63.18%
service/history/task/transfer_standby_task_executor.go 12 85.8%
Totals Coverage Status
Change from base Build 018f54af-1427-4fbc-bc5d-7b9472685578: 0.08%
Covered Lines: 100281
Relevant Lines: 146892

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants