Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace wurstmeister kafka/zookeeper images with bitnami kafka image #5975

Conversation

taylanisikdemir
Copy link
Member

@taylanisikdemir taylanisikdemir commented May 7, 2024

What changed?
Integration tests depend on following images that seems to be gone.

  • wurstmeister/kafka:2.12-2.1.1
  • wurstmeister/zookeeper:3.4.6

These kafka/zookeeper images are 3rd party built and that project doesn't seem to be actively maintained. Not having these images is blocking CI checks for all active PRs at the moment.

To fix this issue I am switching to bitnami/kafka:3.7 image which is newer version of kafka and doesn't have zookeeper dependency anymore. Updated all the docker compose files but didn't test the ones that are not covered by CI. There might be some follow up fixes.

Why?
Unblock CI.

How did you test it?
CI checks in this PR.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.97%. Comparing base (a843a9e) to head (98a86a3).

❗ Current head 98a86a3 differs from pull request most recent head de28065. Consider uploading reports for the commit de28065 to get more accurate results

Additional details and impacted files

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a843a9e...de28065. Read the comment docs.

@coveralls
Copy link

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 018f5439-06b3-4869-b9aa-d080b809f94e

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 96 unchanged lines in 18 files lost coverage.
  • Overall coverage decreased (-0.06%) to 68.094%

Files with Coverage Reduction New Missed Lines %
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
common/persistence/execution_manager.go 2 83.74%
common/cache/lru.go 2 92.89%
service/matching/db.go 2 73.23%
service/history/execution/mutable_state_builder.go 2 71.09%
service/matching/taskListManager.go 2 81.16%
common/persistence/statsComputer.go 2 97.14%
service/history/task/transfer_standby_task_executor.go 3 86.21%
service/history/task/task.go 3 84.81%
common/log/tag/tags.go 3 50.46%
Totals Coverage Status
Change from base Build 018f4ec3-7a67-4bed-b1a9-4481b46860fc: -0.06%
Covered Lines: 100028
Relevant Lines: 146898

💛 - Coveralls

@taylanisikdemir taylanisikdemir changed the title Temporary workaround for broken wurstmeister kafka/zookeeper images Replace wurstmeister kafka/zookeeper images with bitnami kafka image May 7, 2024
@taylanisikdemir taylanisikdemir enabled auto-merge (squash) May 7, 2024 18:06
@taylanisikdemir taylanisikdemir merged commit 4cb4443 into cadence-workflow:master May 7, 2024
17 of 18 checks passed
@taylanisikdemir taylanisikdemir deleted the taylan/temporary_fix_for_kafka_images branch May 7, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants