-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace wurstmeister kafka/zookeeper images with bitnami kafka image #5975
Replace wurstmeister kafka/zookeeper images with bitnami kafka image #5975
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018f5439-06b3-4869-b9aa-d080b809f94eDetails
💛 - Coveralls |
4cb4443
into
cadence-workflow:master
What changed?
Integration tests depend on following images that seems to be gone.
wurstmeister/kafka:2.12-2.1.1
wurstmeister/zookeeper:3.4.6
These kafka/zookeeper images are 3rd party built and that project doesn't seem to be actively maintained. Not having these images is blocking CI checks for all active PRs at the moment.
To fix this issue I am switching to
bitnami/kafka:3.7
image which is newer version of kafka and doesn't have zookeeper dependency anymore. Updated all the docker compose files but didn't test the ones that are not covered by CI. There might be some follow up fixes.Why?
Unblock CI.
How did you test it?
CI checks in this PR.