Api handler test respond activity task failed alternate #5980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibarrajo
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
May 7, 2024
service/frontend/api/handler_test.go
Outdated
| } | ||
|
|
||
| func TestRespondActivityTaskFailed(t *testing.T) { | ||
|
|
There was a problem hiding this comment.
nit: remove empty line at the beginning of function
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Pull Request Test Coverage Report for Build 018f54c6-bb72-4d0c-a877-c16c27e1362aDetails
💛 - Coveralls |
auto-merge was automatically disabled
May 7, 2024 20:58
Base branch was modified
abhishekj720
pushed a commit
to abhishekj720/cadence
that referenced
this pull request
May 7, 2024
…flow#5980) * TestRespondActivityTaskFailed_Success implementation * Alternate test for TerstRespondActivityTaskFailed * code lint
abhishekj720
pushed a commit
to abhishekj720/cadence
that referenced
this pull request
May 7, 2024
…flow#5980) * TestRespondActivityTaskFailed_Success implementation * Alternate test for TerstRespondActivityTaskFailed * code lint
agautam478
pushed a commit
to agautam478/cadence
that referenced
this pull request
May 8, 2024
…flow#5980) * TestRespondActivityTaskFailed_Success implementation * Alternate test for TerstRespondActivityTaskFailed * code lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding test for TestRespondActivityTaskFailed which can be expanded into code paths other than happy-path. Provided test for probing for an error when workflows are shutting down.
This is the alternate test to: #5979
Why?
increasing code coverage
How did you test it?
ran it locally
Potential risks
no changes to functionality
Release notes
Documentation Changes