Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional unit tests for service/history/handler.go #5984

Merged
merged 1 commit into from
May 7, 2024

Conversation

timl3136
Copy link
Member

@timl3136 timl3136 commented May 7, 2024

What changed?
Added unit tests for mutablestate and shard related handler methods

Why?
Improve test coverage and stability

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.62%. Comparing base (e194e5e) to head (18eaa57).
Report is 1 commits behind head on master.

Additional details and impacted files

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e194e5e...18eaa57. Read the comment docs.

@timl3136 timl3136 merged commit 4db60d9 into cadence-workflow:master May 7, 2024
20 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 018f5540-2135-4642-8f71-eecc9203eb85

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 34 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.07%) to 68.482%

Files with Coverage Reduction New Missed Lines %
tools/cli/admin_db_decode_thrift.go 1 71.79%
common/persistence/nosql/utils.go 2 60.0%
service/matching/taskListManager.go 2 80.65%
service/matching/matcher.go 2 91.41%
common/persistence/errors.go 3 25.0%
common/persistence/nosql/nosql_config_store.go 3 44.0%
common/persistence/statsComputer.go 3 96.07%
common/dynamicconfig/configstore/config_store_client.go 4 73.42%
service/history/task/fetcher.go 6 85.05%
service/history/task/cross_cluster_task_processor.go 8 80.79%
Totals Coverage Status
Change from base Build 018f5503-b802-40c5-bbeb-ebb54e6aab3d: 0.07%
Covered Lines: 100587
Relevant Lines: 146880

💛 - Coveralls

agautam478 pushed a commit to agautam478/cadence that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants