Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bench test use grpc #6049

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Conversation

subhash-veluru
Copy link
Contributor

What changed?
Made bench workers to use grpc instead of tchannel transport, and changed development.yaml in config/bench to use 7833 port.

Why?
Since the thrift port is getting deprecated, it reduces the overhead of exposing thrift port of cadence service while bench testing.

How did you test it?
I tested this locally and workers started, All test cases passed. Since its a small change I didn't add test case.

Potential risks
There is no risks for main code as it only changes bench client connection.

Release notes
No it doesn't require anything.

Documentation Changes
Updated Readme in this PR itself

@subhash-veluru
Copy link
Contributor Author

Hi @taylanisikdemir
How to trigger the build for this?

@natemort
Copy link
Member

natemort commented Jun 5, 2024

I've kicked off the build, it requires manual approval per PR for anyone outside of our organization.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (fb4bfce) to head (2b8684c).
Report is 58 commits behind head on master.

Additional details and impacted files

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4bfce...2b8684c. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 018fa548-5231-4e13-87bc-1b6eddb17b19

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 95 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-0.05%) to 69.26%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bench/lib/client.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/matching/tasklist/db.go 2 73.23%
common/persistence/execution_manager.go 2 86.43%
common/persistence/sql/sqlplugin/mysql/task.go 2 73.68%
service/history/task/transfer_active_task_executor.go 2 72.72%
common/persistence/statsComputer.go 2 97.14%
common/persistence/sql/sqlplugin/mysql/db.go 2 79.49%
common/log/tag/tags.go 3 50.46%
service/matching/tasklist/task_list_manager.go 3 75.89%
service/history/queue/timer_queue_processor_base.go 3 77.87%
Totals Coverage Status
Change from base Build 018fa464-40c9-4742-b88d-967555b43b81: -0.05%
Covered Lines: 102043
Relevant Lines: 147334

💛 - Coveralls

@natemort natemort merged commit 30ddb1e into cadence-workflow:master Jun 5, 2024
20 checks passed
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
* changed bench workers to use grpc port instead of tchannel

* updated doc with grpc address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants