-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bench test use grpc #6049
Bench test use grpc #6049
Conversation
Hi @taylanisikdemir |
I've kicked off the build, it requires manual approval per PR for anyone outside of our organization. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
* changed bench workers to use grpc port instead of tchannel * updated doc with grpc address
What changed?
Made bench workers to use grpc instead of tchannel transport, and changed development.yaml in config/bench to use 7833 port.
Why?
Since the thrift port is getting deprecated, it reduces the overhead of exposing thrift port of cadence service while bench testing.
How did you test it?
I tested this locally and workers started, All test cases passed. Since its a small change I didn't add test case.
Potential risks
There is no risks for main code as it only changes bench client connection.
Release notes
No it doesn't require anything.
Documentation Changes
Updated Readme in this PR itself